-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit Fixes - System Changes - Code Refactoring - Mega Merge #17
Open
GalloDaSballo
wants to merge
139
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,223
−585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Curve Claim Flow + Tests + Griefing
Fix: eth transfer
Fix: Try Catch that actually doesn't revert
Dev governance refactor
Recon Campaign Started LiquityPre-Release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mega PR of all changes
This PR will not be merged until the mitigation review is done
The current WIP PR is: #16
This PR collects additional small changes and fixes
5.1 -
Fixed, see: #16
Fix: 5.2 - Try Catch that actually doesn't revert - #5
selfdestruct
,returnbomb
,gasgrief
andreverts
Fix: 5.3 - fix: counted ts fix - #18
@nican0r need coverage here pls
Missing Test here
Can write a basic one:
Given a User Voting contributing X to the total
Removing 100% of votes should remove X off the total
5.4 - WIP - See: #16
5.5 - FIXED - #19
Fix: 5.6 - see 5.2
5.7 -> See 5.4
5.8 -> See 5.4
Fix: 5.9 - Curve Claim Flow + Tests + Griefing - #10
5.10 -> See 5.4
5.11
Awaiting @jltqy See:
fix/voteCheck
May rewrite these
5.12
Ack -> TODO: Review Game Theory
Rest
Pending
NOT MERGED - Fix: V4 Claim Grief Flow - #11
Minor
Unchecked ETH Transfer - #7
Always use
safeTransfer
| bcf897eapprove
is not safe and bold and lqty don't require itEncode and Decode Library with Fuzz Tests
#24